Exclude vertx from bookkeeper-http package #7997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xiaolong.ran <rxl@apache.org>
wolfstudy
requested review from
merlimat,
sijie,
codelipenghui and
jiazhai
and removed request for
merlimat
Signed-off-by: xiaolong.ran <rxl@apache.org>
jiazhai
reviewed
Sep 7, 2020
| </exclusions> | ||
| </dependency> | ||
| <dependency> |
There was a problem hiding this comment.
This tmp fix lgtm. And ideal fix would be changing the io.vertx version in BookKeeper. Please help open an issue/PR in BookKeeper, and add an comments here. So when using the BookKeeper with the fix, we could change this back.
There was a problem hiding this comment.
Yes, i already send a pull request on bk, refer to: apache/bookkeeper#2410
Signed-off-by: xiaolong.ran <rxl@apache.org>
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Sep 8, 2020
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Oct 3, 2020
Signed-off-by: xiaolong.ran <rxl@apache.org> ### Motivation ``` $ mvn dependency:tree|grep vertx ``` Output: ``` [INFO] +- org.apache.bookkeeper.http:vertx-http-server:jar:4.10.0:compile [INFO] +- io.vertx:vertx-core:jar:3.5.3:compile [INFO] +- io.vertx:vertx-web:jar:3.5.3:compile [INFO] | +- io.vertx:vertx-auth-common:jar:3.5.3:compile [INFO] | \- io.vertx:vertx-bridge-common:jar:3.5.3:compile [INFO] | +- org.apache.bookkeeper.http:vertx-http-server:jar:4.10.0:provided [INFO] | +- io.vertx:vertx-core:jar:3.5.3:provided [INFO] | \- io.vertx:vertx-web:jar:3.5.3:provided [INFO] | +- io.vertx:vertx-auth-common:jar:3.5.3:provided [INFO] | \- io.vertx:vertx-bridge-common:jar:3.5.3:provided ``` ### Modifications - exclude `vertx` from bookkeeper-http package and include vertx of `3.5.3` to `vertx-http-server`
codelipenghui
pushed a commit
that referenced
this pull request
Oct 14, 2020
Signed-off-by: xiaolong.ran <rxl@apache.org> ### Motivation ``` $ mvn dependency:tree|grep vertx ``` Output: ``` [INFO] +- org.apache.bookkeeper.http:vertx-http-server:jar:4.10.0:compile [INFO] +- io.vertx:vertx-core:jar:3.5.3:compile [INFO] +- io.vertx:vertx-web:jar:3.5.3:compile [INFO] | +- io.vertx:vertx-auth-common:jar:3.5.3:compile [INFO] | \- io.vertx:vertx-bridge-common:jar:3.5.3:compile [INFO] | +- org.apache.bookkeeper.http:vertx-http-server:jar:4.10.0:provided [INFO] | +- io.vertx:vertx-core:jar:3.5.3:provided [INFO] | \- io.vertx:vertx-web:jar:3.5.3:provided [INFO] | +- io.vertx:vertx-auth-common:jar:3.5.3:provided [INFO] | \- io.vertx:vertx-bridge-common:jar:3.5.3:provided ``` ### Modifications - exclude `vertx` from bookkeeper-http package and include vertx of `3.5.3` to `vertx-http-server` (cherry picked from commit 98233c0)
|
cherry-picked to branch-2.6 |
wolfstudy
added a commit
that referenced
this pull request
Oct 30, 2020
This reverts commit b4b3ecc.
wolfstudy
added a commit
that referenced
this pull request
Oct 30, 2020
Signed-off-by: xiaolong.ran <rxl@apache.org> ### Motivation ``` $ mvn dependency:tree|grep vertx ``` Output: ``` [INFO] +- org.apache.bookkeeper.http:vertx-http-server:jar:4.10.0:compile [INFO] +- io.vertx:vertx-core:jar:3.5.3:compile [INFO] +- io.vertx:vertx-web:jar:3.5.3:compile [INFO] | +- io.vertx:vertx-auth-common:jar:3.5.3:compile [INFO] | \- io.vertx:vertx-bridge-common:jar:3.5.3:compile [INFO] | +- org.apache.bookkeeper.http:vertx-http-server:jar:4.10.0:provided [INFO] | +- io.vertx:vertx-core:jar:3.5.3:provided [INFO] | \- io.vertx:vertx-web:jar:3.5.3:provided [INFO] | +- io.vertx:vertx-auth-common:jar:3.5.3:provided [INFO] | \- io.vertx:vertx-bridge-common:jar:3.5.3:provided ``` ### Modifications - exclude `vertx` from bookkeeper-http package and include vertx of `3.5.3` to `vertx-http-server` (cherry picked from commit 98233c0)
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xiaolong.ran rxl@apache.org
Fixes #7931
Motivation
Output:
Modifications
vertxfrom bookkeeper-http package and include vertx of3.5.3tovertx-http-server