-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude vertx from bookkeeper-http package #7997
Conversation
Signed-off-by: xiaolong.ran <rxl@apache.org>
Signed-off-by: xiaolong.ran <rxl@apache.org>
</exclusions> | ||
</dependency> | ||
<dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tmp fix lgtm. And ideal fix would be changing the io.vertx version in BookKeeper. Please help open an issue/PR in BookKeeper, and add an comments here. So when using the BookKeeper with the fix, we could change this back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, i already send a pull request on bk, refer to: apache/bookkeeper#2410
Signed-off-by: xiaolong.ran <rxl@apache.org>
/pulsarbot run-failure-checks |
1 similar comment
/pulsarbot run-failure-checks |
Signed-off-by: xiaolong.ran <rxl@apache.org> ### Motivation ``` $ mvn dependency:tree|grep vertx ``` Output: ``` [INFO] +- org.apache.bookkeeper.http:vertx-http-server:jar:4.10.0:compile [INFO] +- io.vertx:vertx-core:jar:3.5.3:compile [INFO] +- io.vertx:vertx-web:jar:3.5.3:compile [INFO] | +- io.vertx:vertx-auth-common:jar:3.5.3:compile [INFO] | \- io.vertx:vertx-bridge-common:jar:3.5.3:compile [INFO] | +- org.apache.bookkeeper.http:vertx-http-server:jar:4.10.0:provided [INFO] | +- io.vertx:vertx-core:jar:3.5.3:provided [INFO] | \- io.vertx:vertx-web:jar:3.5.3:provided [INFO] | +- io.vertx:vertx-auth-common:jar:3.5.3:provided [INFO] | \- io.vertx:vertx-bridge-common:jar:3.5.3:provided ``` ### Modifications - exclude `vertx` from bookkeeper-http package and include vertx of `3.5.3` to `vertx-http-server`
Signed-off-by: xiaolong.ran <rxl@apache.org> ### Motivation ``` $ mvn dependency:tree|grep vertx ``` Output: ``` [INFO] +- org.apache.bookkeeper.http:vertx-http-server:jar:4.10.0:compile [INFO] +- io.vertx:vertx-core:jar:3.5.3:compile [INFO] +- io.vertx:vertx-web:jar:3.5.3:compile [INFO] | +- io.vertx:vertx-auth-common:jar:3.5.3:compile [INFO] | \- io.vertx:vertx-bridge-common:jar:3.5.3:compile [INFO] | +- org.apache.bookkeeper.http:vertx-http-server:jar:4.10.0:provided [INFO] | +- io.vertx:vertx-core:jar:3.5.3:provided [INFO] | \- io.vertx:vertx-web:jar:3.5.3:provided [INFO] | +- io.vertx:vertx-auth-common:jar:3.5.3:provided [INFO] | \- io.vertx:vertx-bridge-common:jar:3.5.3:provided ``` ### Modifications - exclude `vertx` from bookkeeper-http package and include vertx of `3.5.3` to `vertx-http-server` (cherry picked from commit 98233c0)
cherry-picked to branch-2.6 |
This reverts commit b4b3ecc.
Signed-off-by: xiaolong.ran <rxl@apache.org> ### Motivation ``` $ mvn dependency:tree|grep vertx ``` Output: ``` [INFO] +- org.apache.bookkeeper.http:vertx-http-server:jar:4.10.0:compile [INFO] +- io.vertx:vertx-core:jar:3.5.3:compile [INFO] +- io.vertx:vertx-web:jar:3.5.3:compile [INFO] | +- io.vertx:vertx-auth-common:jar:3.5.3:compile [INFO] | \- io.vertx:vertx-bridge-common:jar:3.5.3:compile [INFO] | +- org.apache.bookkeeper.http:vertx-http-server:jar:4.10.0:provided [INFO] | +- io.vertx:vertx-core:jar:3.5.3:provided [INFO] | \- io.vertx:vertx-web:jar:3.5.3:provided [INFO] | +- io.vertx:vertx-auth-common:jar:3.5.3:provided [INFO] | \- io.vertx:vertx-bridge-common:jar:3.5.3:provided ``` ### Modifications - exclude `vertx` from bookkeeper-http package and include vertx of `3.5.3` to `vertx-http-server` (cherry picked from commit 98233c0)
Signed-off-by: xiaolong.ran rxl@apache.org
Fixes #7931
Motivation
Output:
Modifications
vertx
from bookkeeper-http package and include vertx of3.5.3
tovertx-http-server