support max consumers per subscription on topic level #8003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangc0276
force-pushed
the
add_max_consumers_per_subscription_on_topic
branch
from
a729baa
to
11b3f9e
Compare
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
2 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Sep 9, 2020
| * @param topicName | ||
| * @return TopicPolicies is exist else return null. | ||
| */ | ||
| private TopicPolicies getTopicPolicies(TopicName topicName) { |
There was a problem hiding this comment.
Looks dup withNonPersistentDispatcherSingleActiveConsumer.java.
| * @param topicName | ||
| * @return TopicPolicies is exist else return null. | ||
| */ | ||
| private TopicPolicies getTopicPolicies(TopicName topicName) { |
There was a problem hiding this comment.
Same as the above comment, I think we can move this method to the BrokerService?
There was a problem hiding this comment.
Thanks for your reply. I have move the getTopicPolicies method to BrokerService, Please take a look again.
codelipenghui
added
component/topic-policy
doc-required
|
/pulsarbot run-failure-checks |
3 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Oct 3, 2020
### Modifications Support set max consumers per subscription on topic level. Support get max consumers per subscription on topic level. Support remove max consumers per subscription on topic level. ### Verifying this change This change added tests and can be verified as follows: - test set topic max consumers per subscription - test remove topic max consumers per subscription - test get topic topic max consumers per subscription - test disabled topic max consumers per subscription
Anonymitaet
added
doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications
Support set max consumers per subscription on topic level.
Support get max consumers per subscription on topic level.
Support remove max consumers per subscription on topic level.
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Documentation
Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (docs / JavaDocs)