-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support max consumers per subscription on topic level #8003
support max consumers per subscription on topic level #8003
Conversation
a729baa
to
11b3f9e
Compare
/pulsarbot run-failure-checks |
/pulsarbot run-failure-checks |
2 similar comments
/pulsarbot run-failure-checks |
/pulsarbot run-failure-checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just left a minor comment
* @param topicName | ||
* @return TopicPolicies is exist else return null. | ||
*/ | ||
private TopicPolicies getTopicPolicies(TopicName topicName) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks dup withNonPersistentDispatcherSingleActiveConsumer.java
.
* @param topicName | ||
* @return TopicPolicies is exist else return null. | ||
*/ | ||
private TopicPolicies getTopicPolicies(TopicName topicName) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as the above comment, I think we can move this method to the BrokerService?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your reply. I have move the getTopicPolicies method to BrokerService, Please take a look again.
/pulsarbot run-failure-checks |
3 similar comments
/pulsarbot run-failure-checks |
/pulsarbot run-failure-checks |
/pulsarbot run-failure-checks |
### Modifications Support set max consumers per subscription on topic level. Support get max consumers per subscription on topic level. Support remove max consumers per subscription on topic level. ### Verifying this change This change added tests and can be verified as follows: - test set topic max consumers per subscription - test remove topic max consumers per subscription - test get topic topic max consumers per subscription - test disabled topic max consumers per subscription
Modifications
Support set max consumers per subscription on topic level.
Support get max consumers per subscription on topic level.
Support remove max consumers per subscription on topic level.
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Documentation
Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (docs / JavaDocs)