[component/functions|component/go] Propagate user-config parameter into instances of Golang pulsar functions #8132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 27, 2020 13:29
vaihtovirta
force-pushed
the
feat/pulsar-function-go/add-user-config-support
branch
from
354ed6a
to
0b91888
Compare
sijie
requested changes
Oct 1, 2020
| @@ -72,8 +73,8 @@ func newInstanceConf() *instanceConf { | |||
| SubscriptionType: pb.SubscriptionType(cfg.SubscriptionType), | |||
| InputSpecs: map[string]*pb.ConsumerSpec{ | |||
| cfg.SourceSpecTopic: { | |||
| SchemaType: cfg.SourceSchemaType, | |||
| IsRegexPattern: cfg.IsRegexPatternSubscription, | |||
| SchemaType: "", | |||
There was a problem hiding this comment.
Why do you change the SchemaType to an empty string?
There was a problem hiding this comment.
Good catch, I might've overlooked after some testing.
I'll revert that.
| SchemaType: cfg.SourceSchemaType, | ||
| IsRegexPattern: cfg.IsRegexPatternSubscription, | ||
| SchemaType: "", | ||
| IsRegexPattern: false, |
|
@sijie Addressed both comments. |
sijie
approved these changes
Oct 2, 2020
sijie
added
area/function
component/go
type/feature
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Nov 13, 2020
…to instances of Golang pulsar functions (apache#8132) ### Motivation Currently, pulsar functions written in Golang have no access to the content of the user-config parameter from admin CLI. That's the simplest way to pass custom configuration into a go function right now because neither secretsMap nor Kubernetes runtime is available for Golang functions yet. **Note**: For the `secretsMap` parameter, the same technique can be used, but this has to be addressed in a separate PR. ### Modifications - Added `String GoInstanceConfig#userConfig` attribute - Propagated user-config parameter in `RuntimeUtils.getGoInstanceCmd` - Exposed userConfig in `pulsar-function-go` and made it available in the `FunctionContext` - Add unit tests for the affected code
|
depends by #8268 |
codelipenghui
pushed a commit
that referenced
this pull request
Dec 7, 2020
…to instances of Golang pulsar functions (#8132) ### Motivation Currently, pulsar functions written in Golang have no access to the content of the user-config parameter from admin CLI. That's the simplest way to pass custom configuration into a go function right now because neither secretsMap nor Kubernetes runtime is available for Golang functions yet. **Note**: For the `secretsMap` parameter, the same technique can be used, but this has to be addressed in a separate PR. ### Modifications - Added `String GoInstanceConfig#userConfig` attribute - Propagated user-config parameter in `RuntimeUtils.getGoInstanceCmd` - Exposed userConfig in `pulsar-function-go` and made it available in the `FunctionContext` - Add unit tests for the affected code (cherry picked from commit d6f18ab)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, pulsar functions written in Golang have no access to the content of the user-config parameter from admin CLI.
That's the simplest way to pass custom configuration into a go function right now because neither secretsMap nor Kubernetes runtime is available for Golang functions yet.
Note: For the
secretsMapparameter, the same technique can be used, but this has to be addressed in a separate PR.Modifications
String GoInstanceConfig#userConfigattributeRuntimeUtils.getGoInstanceCmdpulsar-function-goand made it available in theFunctionContextVerifying this change
This change added tests and can be verified as follows:
RuntimeUtils.getGoInstanceCmdinpulsar-functionsinstanceConfandFunctionContextinpulsar-function-goDoes this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesgo mod tidyinpulsar-function-go.Documentation
The respective documentation has to be updated: User Config#Go
Question: Does it have to be done in the scope of current PR?