fix pulsar service close exception #8197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
requested changes
Oct 4, 2020
| @@ -215,7 +215,9 @@ public void channelInactive(ChannelHandlerContext ctx) throws Exception { | |||
| super.channelInactive(ctx); | |||
| isActive = false; | |||
| log.info("Closed connection from {}", remoteAddress); | |||
| getBrokerService().getInterceptor().onConnectionClosed(this); | |||
| if (getBrokerService().getInterceptor() != null) { | |||
| getBrokerService().getInterceptor().onConnectionClosed(this); | |||
There was a problem hiding this comment.
In BrokerService we are setting this field to null.
We could run into some NPE anyway in the future.
It is better to assign the result of getInterceptor to a local variable and then deference it safely, without calling twice this getter
There was a problem hiding this comment.
@eolivelli Thanks for your feedback. I will use the a local variable to avoid calling twice of getInterceptor.
codelipenghui
approved these changes
Oct 4, 2020
jiazhai
approved these changes
Oct 4, 2020
|
/pulsarbot run-failure-checks |
sijie
approved these changes
Oct 5, 2020
wolfstudy
pushed a commit
that referenced
this pull request
Oct 30, 2020
Fix #8196 ### Motivation In BrokerService#close, it close interceptor first and close workerGroup in the second. However, in workerGroup.shutdownGracefully(), it will call ServerCnx#channelInactive method. The code with bug as follow. ``` getBrokerService().getInterceptor().onConnectionClosed(this); ``` It doesn't check whether `getBrokerService().getInterceptor()` is null and call `onConnectionClosed` may cause NullPointerException. ### Changes 1. In BrokerService#close, close workerGroup first and close interceptor in the second. 2. In ServerCnx#channelInactive, check `getBrokerService().getInterceptor()` whether is null before call onConnectionClosed method. (cherry picked from commit 01cd0bc)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Nov 13, 2020
Fix apache#8196 ### Motivation In BrokerService#close, it close interceptor first and close workerGroup in the second. However, in workerGroup.shutdownGracefully(), it will call ServerCnx#channelInactive method. The code with bug as follow. ``` getBrokerService().getInterceptor().onConnectionClosed(this); ``` It doesn't check whether `getBrokerService().getInterceptor()` is null and call `onConnectionClosed` may cause NullPointerException. ### Changes 1. In BrokerService#close, close workerGroup first and close interceptor in the second. 2. In ServerCnx#channelInactive, check `getBrokerService().getInterceptor()` whether is null before call onConnectionClosed method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8196
Motivation
In BrokerService#close, it close interceptor first and close workerGroup in the second. However, in workerGroup.shutdownGracefully(), it will call ServerCnx#channelInactive method. The code with bug as follow.
It doesn't check whether
getBrokerService().getInterceptor()is null and callonConnectionClosedmay cause NullPointerException.Changes
getBrokerService().getInterceptor()whether is null before call onConnectionClosed method.