Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable replicator to encrypt communication using TLS #824

Merged
merged 1 commit into from
Oct 18, 2017
Merged

Enable replicator to encrypt communication using TLS #824

merged 1 commit into from
Oct 18, 2017
+139 −24

Conversation

massakam
Copy link
Contributor

Motivation

Currently, communication between brokers for geo replication is not using TLS and we cannot enable it.

Modifications

Add replicationTlsEnabled parameter to ServiceConfiguration.
If replicationTlsEnabled is true, communication for replication is encrypted using TLS.

Result

Replicator will be able to replicate messages using TLS.

@massakam massakam self-assigned this Oct 13, 2017
merlimat
merlimat approved these changes Oct 17, 2017
View reviewed changes
Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@merlimat merlimat added the type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages label Oct 17, 2017
@merlimat merlimat added this to the 1.21.0-incubating milestone Oct 17, 2017
yush1ga
yush1ga approved these changes Oct 18, 2017
View reviewed changes
Copy link
Contributor

@yush1ga yush1ga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yush1ga yush1ga merged commit 18aec9a into apache:master Oct 18, 2017
@massakam massakam deleted the tls-replication branch October 18, 2017 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

@yush1ga yush1ga yush1ga approved these changes

Assignees

@massakam massakam

Labels
type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Milestone
1.21.0-incubating
Development

Successfully merging this pull request may close these issues.
3 participants
@massakam @merlimat @yush1ga