Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7994 Missed dryRun on maintenance of secrets. #8286

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

klwilson227
Copy link
Contributor

This change fixes issues in which the dryRun flag was added inadvertantly to the functions management of the namespaces. This causes errors due to namespaces not existing when deploying functions to kuberenetes workers.

@jiazhai
Copy link
Member

jiazhai commented Oct 18, 2020

/pulsarbot run-failure-checks

@jiazhai
Copy link
Member

jiazhai commented Oct 19, 2020

/pulsarbot run-failure-checks

2 similar comments
@jiazhai
Copy link
Member

jiazhai commented Oct 20, 2020

/pulsarbot run-failure-checks

@jiazhai
Copy link
Member

jiazhai commented Oct 20, 2020

/pulsarbot run-failure-checks

@sijie sijie added this to the 2.7.0 milestone Oct 20, 2020
Copy link
Member

@wolfstudy wolfstudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@wolfstudy wolfstudy merged commit 80e2fec into apache:master Oct 21, 2020
wolfstudy pushed a commit that referenced this pull request Oct 30, 2020
This change fixes issues in which the dryRun flag was added inadvertantly to the functions management of the namespaces. This causes errors due to namespaces not existing when deploying functions to kuberenetes workers. 

(cherry picked from commit 80e2fec)
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Nov 13, 2020
This change fixes issues in which the dryRun flag was added inadvertantly to the functions management of the namespaces. This causes errors due to namespaces not existing when deploying functions to kuberenetes workers.
flowchartsman pushed a commit to flowchartsman/pulsar that referenced this pull request Nov 17, 2020
This change fixes issues in which the dryRun flag was added inadvertantly to the functions management of the namespaces. This causes errors due to namespaces not existing when deploying functions to kuberenetes workers.
@klwilson227 klwilson227 deleted the 7994-dryRun branch April 7, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants