[Java Client] Disable batch receive timer for Readers #8381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- since the Reader implementation doesn't use the batch receiving
functionality, it's more efficient to set the timeout to 0 of the
BatchReceivePolicy of the internal consumer of the Reader
implementation
- this disables the timer that would get called every 100ms by default
just for nothing
|
/pulsarbot run-failure-checks |
merlimat
approved these changes
Oct 26, 2020
merlimat
added
the
type/enhancement
|
/pulsarbot run-failure-checks |
|
@wolfstudy this change should be included in 2.6.2. |
Sure, will do it. |
wolfstudy
pushed a commit
that referenced
this pull request
Oct 30, 2020
- since the Reader implementation doesn't use the batch receiving
functionality, it's more efficient to set the timeout to 0 of the
BatchReceivePolicy of the internal consumer of the Reader
implementation
- this disables the timer that would get called every 100ms by default
just for nothing
(cherry picked from commit eea86a5)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Nov 13, 2020
- since the Reader implementation doesn't use the batch receiving
functionality, it's more efficient to set the timeout to 0 of the
BatchReceivePolicy of the internal consumer of the Reader
implementation
- this disables the timer that would get called every 100ms by default
just for nothing
flowchartsman
pushed a commit
to flowchartsman/pulsar
that referenced
this pull request
Nov 17, 2020
- since the Reader implementation doesn't use the batch receiving
functionality, it's more efficient to set the timeout to 0 of the
BatchReceivePolicy of the internal consumer of the Reader
implementation
- this disables the timer that would get called every 100ms by default
just for nothing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the current implementation, each Reader implementation wraps a Consumer implementation.
By default, the consumer implementation will use a BatchReceivePolicy that triggers a task every 100 milliseconds.
Since the Reader implementation doesn't use the batch receiving functionality, it's more efficient to disable the timer.
Modifications
The the timeout is set to 0 for BatchReceivePolicy used for internal consumer of the Reader implementation.
This disables the timer that would get called every 100ms by default just for nothing.