[C++] Implement batch aware producer router #8395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
type/enhancement
merlimat
requested review from
ivankelly,
sijie,
srkukarni,
rdhabalia,
jerrypeng,
jiazhai and
codelipenghui
srkukarni
approved these changes
Oct 29, 2020
BewareMyPower
approved these changes
Nov 5, 2020
|
/pulsarbot run-failure-checks |
merlimat
force-pushed
the
cpp-producer-routing
branch
from
a5a7843
to
56c000f
Compare
codelipenghui
pushed a commit
that referenced
this pull request
Dec 3, 2020
* [C++] Implement batch aware producer router * Fixed tests that relied on old rr distribution * Fixed compilation with older compilers * Fixed test (cherry picked from commit 74803db)
RobertIndie
pushed a commit
to RobertIndie/pulsar
that referenced
this pull request
Dec 8, 2020
* [C++] Implement batch aware producer router * Fixed tests that relied on old rr distribution * Fixed compilation with older compilers * Fixed test
merlimat
added a commit
to merlimat/pulsar
that referenced
this pull request
Dec 19, 2020
merlimat
added a commit
to merlimat/pulsar
that referenced
this pull request
Dec 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Similarly with what we're doing for Java and Go clients, in C++ producer we should apply logic to ensure the round-robin routing is done in a way to maximize the batching factor, by sticking to a partition for a long it takes to fill up a single batch.