[pulsar-broker] configure maxMsgReplDelayInSeconds for each repl-cluster #8409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdhabalia
requested review from
merlimat,
sijie,
jiazhai,
codelipenghui and
nkurihar
sijie
approved these changes
Oct 30, 2020
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Oct 31, 2020
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Nov 13, 2020
…che#8409) ### Motivation `maxMsgReplDelayInSeconds` is useful metrics for replicator n/w monitoring and we should have it in namespace-metrics for each colo. We have added max delay across all replication-clusters in apache#2983 but it will be more useful and make-sense to add at each colo for monitoring purpose. ### Result After fix it should appear in namespace-replicator stats ``` ./pulsar-admin broker-stats monitoring-metrics -i { "metrics": { "brk_max_replication_delay_second": 0.0, "brk_repl_is_connected": 1, "brk_repl_out_rate": 0.03857322653872893, "brk_repl_out_tp_rate": 0.23143935923237358, "brk_replication_backlog": 0.0 }, "dimensions": { "from_cluster": "r1", "namespace": "pulsar/ns", "to_cluster": "r3" } } ```
flowchartsman
pushed a commit
to flowchartsman/pulsar
that referenced
this pull request
Nov 17, 2020
…che#8409) ### Motivation `maxMsgReplDelayInSeconds` is useful metrics for replicator n/w monitoring and we should have it in namespace-metrics for each colo. We have added max delay across all replication-clusters in apache#2983 but it will be more useful and make-sense to add at each colo for monitoring purpose. ### Result After fix it should appear in namespace-replicator stats ``` ./pulsar-admin broker-stats monitoring-metrics -i { "metrics": { "brk_max_replication_delay_second": 0.0, "brk_repl_is_connected": 1, "brk_repl_out_rate": 0.03857322653872893, "brk_repl_out_tp_rate": 0.23143935923237358, "brk_replication_backlog": 0.0 }, "dimensions": { "from_cluster": "r1", "namespace": "pulsar/ns", "to_cluster": "r3" } } ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
maxMsgReplDelayInSecondsis useful metrics for replicator n/w monitoring and we should have it in namespace-metrics for each colo. We have added max delay across all replication-clusters in #2983 but it will be more useful and make-sense to add at each colo for monitoring purpose.Result
After fix it should appear in namespace-replicator stats