[C++] Catch exception thrown by remote_endpoint #8486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
jiazhai
approved these changes
Nov 9, 2020
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Nov 10, 2020
codelipenghui
pushed a commit
that referenced
this pull request
Nov 10, 2020
### Motivation Boost asio `socket::remote_point` may throw `boost::system::system_error` on failure. If the C++ client library was compiled with some low version boost, like 1.54, even if `async_connect` success, the server could still be unreachable and an exception would be thrown by `socket_->remote_endpoint()`. ### Modifications - Catch the exception for `socket_->remote_endpoint()` - Add tests for when client connects to a unreachable service url - Fix header dependency because some boost *.hpp file doesn't include assert.h ### Verifying this change - [ ] Make sure that the change passes the CI checks. This change added tests and can be verified as follows: - Run `testServerConnectError`. (cherry picked from commit 53cd2bb)
|
cherry-picked to branch-2.6 |
codelipenghui
pushed a commit
to streamnative/pulsar-archived
that referenced
this pull request
Nov 13, 2020
### Motivation Boost asio `socket::remote_point` may throw `boost::system::system_error` on failure. If the C++ client library was compiled with some low version boost, like 1.54, even if `async_connect` success, the server could still be unreachable and an exception would be thrown by `socket_->remote_endpoint()`. ### Modifications - Catch the exception for `socket_->remote_endpoint()` - Add tests for when client connects to a unreachable service url - Fix header dependency because some boost *.hpp file doesn't include assert.h ### Verifying this change - [ ] Make sure that the change passes the CI checks. This change added tests and can be verified as follows: - Run `testServerConnectError`. (cherry picked from commit 53cd2bb) (cherry picked from commit 7f04056)
flowchartsman
pushed a commit
to flowchartsman/pulsar
that referenced
this pull request
Nov 17, 2020
### Motivation Boost asio `socket::remote_point` may throw `boost::system::system_error` on failure. If the C++ client library was compiled with some low version boost, like 1.54, even if `async_connect` success, the server could still be unreachable and an exception would be thrown by `socket_->remote_endpoint()`. ### Modifications - Catch the exception for `socket_->remote_endpoint()` - Add tests for when client connects to a unreachable service url - Fix header dependency because some boost *.hpp file doesn't include assert.h ### Verifying this change - [ ] Make sure that the change passes the CI checks. This change added tests and can be verified as follows: - Run `testServerConnectError`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Boost asio
socket::remote_pointmay throwboost::system::system_erroron failure. If the C++ client library was compiled with some low version boost, like 1.54, even ifasync_connectsuccess, the server could still be unreachable and an exception would be thrown bysocket_->remote_endpoint().Modifications
socket_->remote_endpoint()Verifying this change
This change added tests and can be verified as follows:
testServerConnectError.