[C++] Add consumer's configs for reader #8905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Dec 15, 2020
codelipenghui
pushed a commit
that referenced
this pull request
Dec 21, 2020
### Motivation
C++ reader cannot set some consumer's configs. Like `CryptoReader`, if the config is not supported for reader, then reader cannot decrypt encrypted messages. Also, reader cannot set other configs like `AckGroupingTimeMs` so that reader cannot control the behavior of `AckGroupingTracker`.
### Modifications
- Add other consumer's configs for reader, except:
- NegativeAckRedeliveryDelayMs: reader has no chance to call `negativeAcknowledge`
- BrokerConsumerStatsCacheTimeInMs: reader has no chance to call `getBrokerConsumerStatsAsync`
- KeySharedPolicy and ConsumerType: reader only supports Exclusive subscription now
- MaxTotalReceiverQueueSizeAcrossPartitions: reader doesn't support partitioned topics now
- PatternAutoDiscoveryPeriod: reader doesn't support regex subscription now
- Add some fields to get the consumer config before reader's internal consumer is created, then add some unit tests for the consumer config.
(cherry picked from commit a3ac12e)
codelipenghui
pushed a commit
that referenced
this pull request
Dec 21, 2020
### Motivation
C++ reader cannot set some consumer's configs. Like `CryptoReader`, if the config is not supported for reader, then reader cannot decrypt encrypted messages. Also, reader cannot set other configs like `AckGroupingTimeMs` so that reader cannot control the behavior of `AckGroupingTracker`.
### Modifications
- Add other consumer's configs for reader, except:
- NegativeAckRedeliveryDelayMs: reader has no chance to call `negativeAcknowledge`
- BrokerConsumerStatsCacheTimeInMs: reader has no chance to call `getBrokerConsumerStatsAsync`
- KeySharedPolicy and ConsumerType: reader only supports Exclusive subscription now
- MaxTotalReceiverQueueSizeAcrossPartitions: reader doesn't support partitioned topics now
- PatternAutoDiscoveryPeriod: reader doesn't support regex subscription now
- Add some fields to get the consumer config before reader's internal consumer is created, then add some unit tests for the consumer config.
(cherry picked from commit a3ac12e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
C++ reader cannot set some consumer's configs. Like
CryptoReader, if the config is not supported for reader, then reader cannot decrypt encrypted messages. Also, reader cannot set other configs likeAckGroupingTimeMsso that reader cannot control the behavior ofAckGroupingTracker.Modifications
negativeAcknowledgegetBrokerConsumerStatsAsyncVerifying this change
This change added tests and can be verified as follows:
ReaderConfigurationTestDoes this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation