Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support deliverAt and deliverAfter attribute for Websocket producer. #8945

Merged
merged 2 commits into from
Dec 14, 2020
Merged

Support deliverAt and deliverAfter attribute for Websocket producer. #8945

merged 2 commits into from
Dec 14, 2020

Conversation

MarvinCai
Copy link
Contributor

Motivation

Support deliverAt and deliverAfter attribute for Websocket producer

Modifications

Apply deliverAt and deliverAfter to message builder for Websocket message build if not negative.

Verifying this change

Added unit test to verify attributes set on message builder.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): no
  • The public API: no
  • The schema: no
  • The default values of configurations: no
  • The wire protocol: no
  • The rest endpoints: no
  • The admin cli options: no
  • Anything that affects deployment: no

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@MarvinCai MarvinCai mentioned this pull request Dec 13, 2020
Merged
@sijie
Copy link
Member

sijie commented Dec 14, 2020

/pulsarbot run-failure-checks

@sijie sijie added this to the 2.8.0 milestone Dec 14, 2020
@sijie sijie added area/websocket type/feature The PR added a new feature or issue requested a new feature labels Dec 14, 2020
eolivelli
eolivelli approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@MarvinCai
Copy link
Contributor Author

/pulsarbot run-failure-checks

@hpvd hpvd mentioned this pull request Dec 14, 2020
Closed
@sijie sijie merged commit 7be1b8d into apache:master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie approved these changes

@eolivelli eolivelli eolivelli approved these changes

Assignees

@MarvinCai MarvinCai

Labels
area/websocket type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MarvinCai @sijie @eolivelli