-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pulsar-client-api] Fix Unavailable Hash Range Condition #9041
Merged
sijie
merged 2 commits into
apache:master
from
k2la:fix_unavailable_hash_range_condition
Dec 24, 2020
Merged
[pulsar-client-api] Fix Unavailable Hash Range Condition #9041
sijie
merged 2 commits into
apache:master
from
k2la:fix_unavailable_hash_range_condition
Dec 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
Dec 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch
/pulsarbot run-failure-checks |
sijie
approved these changes
Dec 23, 2020
/pulsarbot run-failure-checks |
2 similar comments
/pulsarbot run-failure-checks |
/pulsarbot run-failure-checks |
codelipenghui
pushed a commit
to codelipenghui/incubator-pulsar
that referenced
this pull request
Jan 6, 2021
### Motivation https://github.com/apache/pulsar/blob/3b2c8526a96fc90e948dbeb510e8400a628c749a/pulsar-client-api/src/main/java/org/apache/pulsar/client/api/KeySharedPolicy.java#L110-L112 When range is [0, 65536], the above condition is false. ### Modification Change from `range1.getEnd() > DEFAULT_HASH_RANGE_SIZE` to `range1.getEnd() >= DEFAULT_HASH_RANGE_SIZE`. (cherry picked from commit 48779bd)
codelipenghui
pushed a commit
that referenced
this pull request
Jan 7, 2021
### Motivation https://github.com/apache/pulsar/blob/3b2c8526a96fc90e948dbeb510e8400a628c749a/pulsar-client-api/src/main/java/org/apache/pulsar/client/api/KeySharedPolicy.java#L110-L112 When range is [0, 65536], the above condition is false. ### Modification Change from `range1.getEnd() > DEFAULT_HASH_RANGE_SIZE` to `range1.getEnd() >= DEFAULT_HASH_RANGE_SIZE`. (cherry picked from commit 48779bd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
pulsar/pulsar-client-api/src/main/java/org/apache/pulsar/client/api/KeySharedPolicy.java
Lines 110 to 112 in 3b2c852
When range is [0, 65536], the above condition is false.
Modification
Change from
range1.getEnd() > DEFAULT_HASH_RANGE_SIZE
torange1.getEnd() >= DEFAULT_HASH_RANGE_SIZE
.