Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connector]fix debezium-connector error log #9063

Merged
merged 2 commits into from
Dec 29, 2020

Conversation

yufan022
Copy link
Contributor

@yufan022 yufan022 commented Dec 25, 2020

Motivation

debezium-connector exception message not clear.

Modifications

when debezium-connector throw exception, these code will not be execute:

// getRecordSequence is empty
errorMsg = String.format("Failed to publish to topic [%s] with error [%s] with src sequence id [%s]", topic, throwable.getMessage(), record.getRecordSequence().get());
log.error(errorMsg);

After repair:

17:42:43,274 ERROR [public/default/debezium-mysql-source-exchange-0] [instance: 0] PulsarSink - Failed to publish to topic [public/default/xx.xx.xx] with error [org.apache.pulsar.client.api.PulsarClientException$InvalidMessageException: Message size is bigger than 5242880 bytes]

@codelipenghui codelipenghui added this to the 2.8.0 milestone Dec 26, 2020
@codelipenghui
Copy link
Contributor

/pulsarbot run-failure-checks

@codelipenghui
Copy link
Contributor

/pulsarbot run-failure-checks

1 similar comment
@yufan022
Copy link
Contributor Author

/pulsarbot run-failure-checks

@codelipenghui codelipenghui merged commit 19ff4c3 into apache:master Dec 29, 2020
codelipenghui pushed a commit that referenced this pull request Jan 6, 2021
### Motivation

debezium-connector exception message not clear.

### Modifications

when debezium-connector throw exception, these code will not be execute:
```
// getRecordSequence is empty
errorMsg = String.format("Failed to publish to topic [%s] with error [%s] with src sequence id [%s]", topic, throwable.getMessage(), record.getRecordSequence().get());
log.error(errorMsg);
```

After repair:
```
17:42:43,274 ERROR [public/default/debezium-mysql-source-exchange-0] [instance: 0] PulsarSink - Failed to publish to topic [public/default/xx.xx.xx] with error [org.apache.pulsar.client.api.PulsarClientException$InvalidMessageException: Message size is bigger than 5242880 bytes]
```

(cherry picked from commit 19ff4c3)
@codelipenghui codelipenghui added the cherry-picked/branch-2.7 Archived: 2.7 is end of life label Jan 7, 2021
codelipenghui pushed a commit that referenced this pull request Jan 7, 2021
### Motivation

debezium-connector exception message not clear.

### Modifications

when debezium-connector throw exception, these code will not be execute:
```
// getRecordSequence is empty
errorMsg = String.format("Failed to publish to topic [%s] with error [%s] with src sequence id [%s]", topic, throwable.getMessage(), record.getRecordSequence().get());
log.error(errorMsg);
```

After repair:
```
17:42:43,274 ERROR [public/default/debezium-mysql-source-exchange-0] [instance: 0] PulsarSink - Failed to publish to topic [public/default/xx.xx.xx] with error [org.apache.pulsar.client.api.PulsarClientException$InvalidMessageException: Message size is bigger than 5242880 bytes]
```

(cherry picked from commit 19ff4c3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants