[pulsar-broker] Fix: handle topic loading failure due to broken schema ledger #9212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdhabalia
requested review from
merlimat,
sijie,
jiazhai,
codelipenghui and
nkurihar
rdhabalia
force-pushed
the
schema_fail
branch
from
b7b579d
to
fbe7fb9
Compare
|
/pulsarbot run-failure-checks |
eolivelli
approved these changes
Jan 15, 2021
| producer.close(); | ||
|
|
||
| String key = TopicName.get(fqtnOne).getSchemaName(); | ||
| BookkeeperSchemaStorage schemaStrogate = (BookkeeperSchemaStorage) pulsar.getSchemaStorage(); |
sijie
reviewed
Jan 18, 2021
| @@ -41,6 +41,8 @@ | |||
|
|
|||
| CompletableFuture<SchemaVersion> deleteSchemaStorage(String schemaId); | |||
|
|
|||
| CompletableFuture<SchemaVersion> deleteSchemaStorage(String schemaId, boolean forcefully); | |||
There was a problem hiding this comment.
that will be tricky because deleteSchemaStorage(schemaId) calls deleteSchemaStorage(schemaId, false) . and we can't define default behavior of deleteSchemaStorage(schemaId, false) by calling existing deleteSchemaStorage(schemaId) because it creates cyclic call.
| @@ -32,6 +32,8 @@ | |||
|
|
|||
| CompletableFuture<List<CompletableFuture<StoredSchema>>> getAll(String key); | |||
|
|
|||
| CompletableFuture<SchemaVersion> delete(String key, boolean forcefully); | |||
| trimDeletedSchemaAndGetList(list); | ||
| // clean up the broken schema from zk | ||
| deleteSchemaStorage(schemaId, true).handle((sv, th) -> { | ||
| log.info("Deletion of {} {}", schemaId, |
There was a problem hiding this comment.
What a user needs to do when he/she reads this message? Especially if it is "Deletion of ... failed", it might be worth adding more details for the "failed" case.
|
/pulsarbot run-failure-checks |
sijie
approved these changes
Jan 21, 2021
|
/pulsarbot run-failure-checks |
…a ledger add more error log fix list assignment
rdhabalia
force-pushed
the
schema_fail
branch
from
63f6953
to
e4634f2
Compare
merlimat
pushed a commit
to merlimat/pulsar
that referenced
this pull request
Apr 6, 2021
…a ledger (apache#9212) add more error log fix list assignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Sometimes schema ledger gets deleted but failed to clean up schema-locator in zk which can make the topic unavailable and inaccessible in the broker. It mainly happens when the broker tries to delete an inactive topic and the user tries to connect the producer again to that topic and can't access the topic due to the below error:
In this case, if the storage ledger doesn't exist then it's a non-recoverable error and the broker should be resilient to clean up the broken schema locator and allow the topic to load again.
client-error
Broker-error
Modification