Handle web application exception to redirect request #9228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Motivation* `validateNamespaceBundleOwnership` throws a web application exception with `Response.temporaryRedirect(redirect)` to redirect the request to the owner broker. But the web application exception is a runtime exception. If you don't handle and propagate it correctly, it will cause web request to be hang. PR apache#8746 changed some web calls to async but it doesn't handle the web application exception. It causes `topics list` with non-persistent topics to be hang. This pull request make sure the callers of `validateNamespaceBundleOwnership` catch and propagate the exceptions to web response.
zymap
approved these changes
Jan 18, 2021
codelipenghui
approved these changes
Jan 18, 2021
jiazhai
approved these changes
Jan 18, 2021
|
/pulsarbot run-failure-checks |
2 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
codelipenghui
pushed a commit
that referenced
this pull request
Jan 19, 2021
*Motivation* `validateNamespaceBundleOwnership` throws a web application exception with `Response.temporaryRedirect(redirect)` to redirect the request to the owner broker. But the web application exception is a runtime exception. If you don't handle and propagate it correctly, it will cause web request to be hang. PR #8746 changed some web calls to async but it doesn't handle the web application exception. It causes `topics list` with non-persistent topics to be hang. This pull request make sure the callers of `validateNamespaceBundleOwnership` catch and propagate the exceptions to web response. (cherry picked from commit aaa27c3)
merlimat
pushed a commit
to merlimat/pulsar
that referenced
this pull request
Apr 6, 2021
*Motivation* `validateNamespaceBundleOwnership` throws a web application exception with `Response.temporaryRedirect(redirect)` to redirect the request to the owner broker. But the web application exception is a runtime exception. If you don't handle and propagate it correctly, it will cause web request to be hang. PR apache#8746 changed some web calls to async but it doesn't handle the web application exception. It causes `topics list` with non-persistent topics to be hang. This pull request make sure the callers of `validateNamespaceBundleOwnership` catch and propagate the exceptions to web response.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
validateNamespaceBundleOwnershipthrows a web application exception withResponse.temporaryRedirect(redirect)to redirect the request to the owner broker. But the web application exception is a runtime exception. If you don't
handle and propagate it correctly, it will cause web request to be hang.
PR #8746 changed some web calls to async but it doesn't handle the web application exception. It causes
topics listwith non-persistent topics to be hang.
This pull request make sure the callers of
validateNamespaceBundleOwnershipcatch and propagate the exceptions toweb response.