Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle web application exception to redirect request #9228

Merged
merged 3 commits into from
Jan 19, 2021
Merged

Handle web application exception to redirect request #9228

merged 3 commits into from
Jan 19, 2021

Commits on Jan 18, 2021

  1. Handle web application exception to redirect request 

    *Motivation*

`validateNamespaceBundleOwnership` throws a web application exception with `Response.temporaryRedirect(redirect)`
to redirect the request to the owner broker. But the web application exception is a runtime exception. If you don't
handle and propagate it correctly, it will cause web request to be hang.

PR apache#8746 changed some web calls to async but it doesn't handle the web application exception. It causes `topics list`
with non-persistent topics to be hang.

This pull request make sure the callers of `validateNamespaceBundleOwnership` catch and propagate the exceptions to
web response.
    @sijie
    sijie committed Jan 18, 2021
    Configuration menu
    Copy the full SHA
    ea7188c View commit details
    Browse the repository at this point in the history

  2. Fix error message

    @sijie
    sijie committed Jan 18, 2021
    Configuration menu
    Copy the full SHA
    a88a2be View commit details
    Browse the repository at this point in the history

  3. Add test

    @codelipenghui
    codelipenghui committed Jan 18, 2021
    Configuration menu
    Copy the full SHA
    04e1006 View commit details
    Browse the repository at this point in the history