Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose ReachedEndOfTopic in Reader/Consumer API #9381

Merged
merged 7 commits into from
Feb 22, 2021
Merged

Expose ReachedEndOfTopic in Reader/Consumer API #9381

merged 7 commits into from
Feb 22, 2021

Conversation

MarvinCai
Copy link
Contributor

Fixes #2687

Motivation

Expose ReachedEndOfTopic in Reader/Consumer API

Modifications

Add a request of type isEndOfTopic to check if consumer/reader has reached end of topic and send response based on result.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API: yes
  • The schema: no
  • The default values of configurations: no
  • The wire protocol: no
  • The rest endpoints: no
  • The admin cli options: no
  • Anything that affects deployment: no

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? docs

@codelipenghui codelipenghui added this to the 2.8.0 milestone Jan 31, 2021
codelipenghui
codelipenghui reviewed Jan 31, 2021
View reviewed changes
Copy link
Contributor

@codelipenghui codelipenghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a test for the new API?

@MarvinCai
Copy link
Contributor Author

@codelipenghui Added unit test, please take another look.

@MarvinCai
Copy link
Contributor Author

/pulsarbot run-failure-checks

1 similar comment
@MarvinCai
Copy link
Contributor Author

/pulsarbot run-failure-checks

@sijie sijie added area/client java type/feature The PR added a new feature or issue requested a new feature labels Feb 9, 2021
@sijie
Copy link
Member

sijie commented Feb 9, 2021

@codelipenghui Can you review it again?

codelipenghui
codelipenghui approved these changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@codelipenghui codelipenghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just left a minor comment.

pulsar-websocket/src/main/java/org/apache/pulsar/websocket/ConsumerHandler.java Outdated Show resolved Hide resolved
@MarvinCai
Copy link
Contributor Author

/pulsarbot run-failure-checks

1 similar comment
@MarvinCai
Copy link
Contributor Author

/pulsarbot run-failure-checks

@MarvinCai
Copy link
Contributor Author

/pulsarbot run-failure-checks

@sijie sijie merged commit 65fed8b into apache:master Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

Assignees

@MarvinCai MarvinCai

Labels
area/client type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

Websocket API - Expose ReachedEndOfTopic in Reader/Consumer API
3 participants
@MarvinCai @sijie @codelipenghui