Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket API - Expose ReachedEndOfTopic in Reader/Consumer API #2687

Closed
sfescape opened this issue Oct 1, 2018 · 6 comments · Fixed by #9381
Closed

Websocket API - Expose ReachedEndOfTopic in Reader/Consumer API #2687

sfescape opened this issue Oct 1, 2018 · 6 comments · Fixed by #9381
Labels
area/client area/websocket help wanted type/feature The PR added a new feature or issue requested a new feature

Comments

@sfescape
Copy link

sfescape commented Oct 1, 2018

It would be very helpful if there was an ability to test ReachedEndOfTopic. It's not clear to me when you can stop reading if you're only interested in traversing existing messages for a topic.

@jerrypeng
Copy link
Contributor

jerrypeng commented Oct 1, 2018

@sfescape the Reader and Consumer API does have this functionality:

reader.hasReachedEndOfTopic()

@sfescape
Copy link
Author

sfescape commented Oct 1, 2018

In looking at the Websocket API documentation, I don't see anything in the endpoint responses that give me that information. I understand it's available in the other interfaces.

@sijie
Copy link
Member

sijie commented Oct 2, 2018

@sfescape Currently this feature is not available in websocket. you can check this out for the feature parity between clients: https://github.com/apache/pulsar/wiki/Client-Features-Matrix

@sijie sijie added area/client type/feature The PR added a new feature or issue requested a new feature area/websocket labels Oct 2, 2018
@sfescape
Copy link
Author

sfescape commented Oct 2, 2018

Thank you, this feature seems to be "Reader hasMessageAvailable". This project doesn't seem to use JIRA, is there a place I can go look for any roadmap on websocket API features?

@sijie
Copy link
Member

sijie commented Oct 2, 2018

@sfescape we are using github issues for the issue management. the wiki page is for tracking the feature parity. we are currently catching up on c++ and python (we are almost caught up there). however regarding websocket, it is still in the backlog. we put that in low priority since there is no real asks before. we will try to prioritize it since now we are seeing requests.

sijie pushed a commit that referenced this issue Feb 22, 2021
Fixes #2687

### Motivation
Expose ReachedEndOfTopic in Reader/Consumer API

### Modifications

Add a request of type `isEndOfTopic` to check if consumer/reader has reached end of topic and send response based on result.
@hpvd
Copy link

hpvd commented Feb 22, 2021

nice :-)
with having this, feature matrix shoud be updated: https://github.com/apache/pulsar/wiki/Client-Features-Matrix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/client area/websocket help wanted type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants