[pulsar-functions] move metricsPort to InstanceConfig #9610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
zymap
approved these changes
Feb 19, 2021
zymap
reviewed
Feb 19, 2021
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/RuntimeUtils.java
Outdated
Show resolved
Hide resolved
freeznet
force-pushed
the
freeznet/add-metrics-port-into-instance-config
branch
from
02f3a68
to
88fa0e8
Compare
|
/pulsarbot run-failure-checks |
ivankelly
pushed a commit
to ivankelly/pulsar
that referenced
this pull request
Aug 10, 2021
Master Issue: apache#9177 As discussed in apache#9318, both @zymap and @wolfstudy suggested, to add `metricsPort` as a field of `InstanceConfig`. - add metricsPort to InstanceConfig - add hasValidMetricsPort to InstanceConfig to check if metrics port is valid - applied changes to k8s runtime & process runtime
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #9177
Motivation
As discussed in #9318, both @zymap and @wolfstudy suggested, to add
metricsPortas a field ofInstanceConfig.Modifications
metricsPorttoInstanceConfighasValidMetricsPorttoInstanceConfigto check if metrics port is validVerifying this change