Fix cannot consume using older subscriptions if max subscription limi… #9758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
Mar 1, 2021
codelipenghui
requested review from
sijie,
hangc0276,
codelipenghui,
jiazhai,
merlimat and
zymap
|
/pulsarbot run-failure-checks |
zymap
approved these changes
Mar 1, 2021
zymap
pushed a commit
that referenced
this pull request
Mar 1, 2021
#9758) Fixes #9755 ### Motivation If maxSubscriptionsPerTopic is set in the broker (or even as a namespace policy), once this limit is reached, broker does not allow consumers to be created for even older subscriptions. ### Modifications Existing subscriptions are not restricted ### Verifying this change TopicPoliciesTest#testMaxSubscriptionsPerTopicWithExistingSubs (cherry picked from commit 52a2863)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9755
Motivation
If maxSubscriptionsPerTopic is set in the broker (or even as a namespace policy), once this limit is reached, broker does not allow consumers to be created for even older subscriptions.
Modifications
Existing subscriptions are not restricted
Verifying this change
TopicPoliciesTest#testMaxSubscriptionsPerTopicWithExistingSubs