Fix topic ownership is not checked when get topic policy (target branch-2.7) #9781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch 2.7) 1. Currently, the API of topic policies does not check the ownership of topic. In the case of multiple brokers, a `cache not init error` will appear.
zymap
requested review from
315157973 and
codelipenghui
and removed request for
315157973
315157973
reviewed
Mar 3, 2021
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java
Show resolved
Hide resolved
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
|
Do not rerun the test. I can reproduce the errors on local. |
|
ping @315157973 @codelipenghui PTAL. Thanks |
codelipenghui
approved these changes
Mar 5, 2021
zymap
added a commit
to streamnative/pulsar-archived
that referenced
this pull request
Mar 5, 2021
…ch-2.7) (apache#9781) ### Motivation 1. Currently, the API of topic policies does not check the ownership of topic. In the case of multiple brokers, a `cache not init error` will appear. 2. The parameter validation of the read and write API should not be the same, and the read API should not verify `validatePoliciesReadOnlyAccess()`. If `ReadOnly` is set, the read API will also be abnormal. 3. General API should not use `validateAdminAccessForTenant()`. The original PR is apache#9767
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the API of topic policies does not check the ownership of topic. In the case of multiple brokers, a
cache not init errorwill appear.The parameter validation of the read and write API should not be the same, and the read API should not verify
validatePoliciesReadOnlyAccess(). IfReadOnlyis set, the read API will also be abnormal.General API should not use
validateAdminAccessForTenant().The original PR is #9767