Fix topic ownership is not checked #9767
Conversation
|
@315157973 can you please add tests that cover your fix ? You are removing the assertions from PersistentTopicBase. |
I will add unit tests later. Topic policies currently only exist on V2，so are those assertions |
There was a problem hiding this comment.
Thanks @315157973 , Could you please add a multiple brokers test case since the problem can't reproduce on a single broker cluster. We need to ensure no matter the admin to call which broker of the cluster, it can get the correct policy data. So my suggestion is to check the returned policy multiple times for different brokers.
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Outdated
Show resolved
Hide resolved
codelipenghui
added
release/2.7.1
component/topic-policy
type/bug
…ch-2.7) (#9781) ### Motivation 1. Currently, the API of topic policies does not check the ownership of topic. In the case of multiple brokers, a `cache not init error` will appear. 2. The parameter validation of the read and write API should not be the same, and the read API should not verify `validatePoliciesReadOnlyAccess()`. If `ReadOnly` is set, the read API will also be abnormal. 3. General API should not use `validateAdminAccessForTenant()`. The original PR is #9767
…ch-2.7) (apache#9781) ### Motivation 1. Currently, the API of topic policies does not check the ownership of topic. In the case of multiple brokers, a `cache not init error` will appear. 2. The parameter validation of the read and write API should not be the same, and the read API should not verify `validatePoliciesReadOnlyAccess()`. If `ReadOnly` is set, the read API will also be abnormal. 3. General API should not use `validateAdminAccessForTenant()`. The original PR is apache#9767
### Motivation 1. Currently, the API of topic policies does not check the ownership of topic. In the case of multiple brokers, a `cache not init error` will appear.
Motivation
Currently, the API of topic policies does not check the ownership of topic. In the case of multiple brokers, a
cache not init errorwill appear.The parameter validation of the read and write API should not be the same, and the read API should not verify
validatePoliciesReadOnlyAccess(). IfReadOnlyis set, the read API will also be abnormal.General API should not use
validateAdminAccessForTenant().