DISPATCH-113 -- expose topology_last_changed to management #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ted-ross
requested changes
Nov 23, 2016
There was a problem hiding this comment.
Please use an integer seconds-since-the-epoch for this value. Then you can update qdstat -n to look like the following:
$ qdstat -n
Routers in the Network
Last Topology Change: Wed Nov 23 14:56:11 2016
router-id next-hop link
===========================
QDR.A - 1
QDR.B - 0
QDR.C QDR.A -
QDR.D QDR.A -
QDR.X (self) -
QDR.Y QDR.A -
| }, | ||
| "lastTopoChange": { | ||
| "description": "Timestamp showing the most recent change to this node's neighborhood.", | ||
| "type": "string" |
There was a problem hiding this comment.
This should be an integer, not a string. Seconds since the epoch is more than sufficient granularity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.