Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DISPATCH-113 -- expose topology_last_changed to management #117

Closed
wants to merge 5 commits into from
Closed

DISPATCH-113 -- expose topology_last_changed to management #117

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c5f71aa
DISPATCH-113 -- expose topology_last_changed to management
mgoulish Nov 23, 2016
356c8ec
DISPATCH-113 -- make qdstat show last topo change.
mgoulish Nov 28, 2016
84cb922
DISPATCH-113 -- use integer: second-granularity is plenty.
mgoulish Nov 28, 2016
d1dd7ba
DISPATCH-113 -- use interegr, not string. Also clarify GMT in printout
mgoulish Nov 28, 2016
3a3e793
DISPATCH-113 -- messed up the time import statement.
mgoulish Nov 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions python/qpid_dispatch/management/qdrouter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1209,7 +1209,12 @@
"cost": {
"description": "Reachability cost",
"type": "integer"
},
"lastTopoChange": {
"description": "Timestamp showing the most recent change to this node's neighborhood.",
"type": "string"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be an integer, not a string. Seconds since the epoch is more than sufficient granularity.

}

}
},

Expand Down
3 changes: 2 additions & 1 deletion python/qpid_dispatch_internal/router/node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ def refresh_entity(self, attributes):
"linkState": [ls for ls in self.link_state.peers], # List of neighbour nodes
"nextHop": "(self)",
"validOrigins": [],
"address": Address.topological(self.my_id, area=self.container.area)
"address": Address.topological(self.my_id, area=self.container.area),
"lastTopoChange" : "%10.6f" % self.last_topology_change
})


Expand Down