Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DISPATCH-1716 Don't set -Wl,-z,defs in -fsanitize= builds with Clang #777

Merged
merged 7 commits into from Jul 21, 2020
Merged

DISPATCH-1716 Don't set -Wl,-z,defs in -fsanitize= builds with Clang #777

merged 7 commits into from Jul 21, 2020

Conversation

jiridanek
Copy link
Contributor

No description provided.

@jiridanek jiridanek requested a review from kgiusti July 19, 2020 12:20
@jiridanek jiridanek self-assigned this Jul 19, 2020
@jiridanek
Copy link
Contributor Author

This is genuinely funny. Both the default virtualenv version (pypa/virtualenv#1740) and the latest one (pypa/virtualenv#1873) contain a bug which breaks tox on Focal Fossa.

@jiridanek
Copy link
Contributor Author

jiridanek commented Jul 21, 2020 •
edited

I don't have any significantly better ideas how to parameterize the -Wl,-z,defs option, so I'll leave it at this.

I'm going to squash and merge the PR at the eod today, unless somebody complains.

@jiridanek jiridanek merged commit 1fb8b07 into apache:master Jul 21, 2020
@jiridanek jiridanek deleted the jd_2020_07_clang_asan_link branch July 21, 2020 17:13
ChugR pushed a commit to ChugR/qpid-dispatch that referenced this pull request Oct 13, 2022
@jiridanek
Issue apache#767: Temporarily disable leaking TCP adapter benchmarks …
5a2a249 
…tests (apache#777)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgiusti kgiusti Awaiting requested review from kgiusti

Assignees

@jiridanek jiridanek

Labels
ready to merge
Projects
None yet
Milestone
No milestone
1 participant
@jiridanek