DISPATCH-1660: Avoid assert in proton by not settling delivery #767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The assertion is 'delivery must not be local.settled'. This commit avoids setting local.settled. The connection is never again read and no new deliveries on this link or connection are created.
Contributor
Author
|
Before this patch a system may run the test more than two thousand times before seeing the failure. The sequence of events that are special to trigger the assert remain a mystery. |
Contributor
Author
|
This change causes failures in system_tests_policy_oversize_compound and is hereby withdrawn. |
ChugR
pushed a commit
to ChugR/qpid-dispatch
that referenced
this pull request
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The qpid-proton assertion is 'delivery must not be local.settled'.
This commit avoids setting local.settled. The connection is never
again read and no new deliveries on this link or connection are
created.