Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROTON-1800: issue not completely fixed, ignore the failing test #253

Merged
merged 2 commits into from Jun 2, 2020

Conversation

jiridanek
Copy link
Contributor

@astitcher this implements the decorator you suggested to skip test if AssertionErrors occurred.

@jiridanek jiridanek requested a review from astitcher May 30, 2020 10:46
@astitcher
Copy link
Member

astitcher commented Jun 2, 2020

I think the name of the new decorator is too general. How about something like "skipOnFailure" or perhaps "ignoreFailure"?

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2020

Codecov Report

Merging #253 into master will increase coverage by 0.00%.
The diff coverage is 81.81%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #253   +/-   ##
=======================================
  Coverage   83.09%   83.09%           
=======================================
  Files         339      339           
  Lines       41362    41368    +6     
=======================================
+ Hits        34368    34373    +5     
- Misses       6994     6995    +1     
Impacted Files Coverage Δ
...on/test_PROTON_1800_syncrequestresponse_fd_leak.py 91.20% <81.81%> (-1.30%) ⬇️
c/src/proactor/epoll.c 81.54% <0.00%> (-0.17%) ⬇️
c/tests/threaderciser.c 83.21% <0.00%> (-0.06%) ⬇️
c/src/core/codec.c 82.61% <0.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b34bbea...032094a. Read the comment docs.

@jiridanek jiridanek merged commit 65a5d9e into apache:master Jun 2, 2020
@jiridanek jiridanek deleted the jd_2020_05_fixc99 branch June 2, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants