Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROTON-2220 Regenerate test certificates with long expiry #314

Merged

Conversation

jiridanek
Copy link
Contributor

No description provided.

@jiridanek
Copy link
Contributor Author

I checked the generated cert and this did not work out as I intended. I will try again. At least, we have the ci result.

@codecov-commenter
Copy link

codecov-commenter commented May 18, 2021

Codecov Report

Merging #314 (367eb35) into main (06c7e64) will increase coverage by 19.17%.
The diff coverage is n/a.

❗ Current head 367eb35 differs from pull request most recent head 7c6ed41. Consider uploading reports for the commit 7c6ed41 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##             main     #314       +/-   ##
===========================================
+ Coverage   69.17%   88.34%   +19.17%     
===========================================
  Files         352       47      -305     
  Lines       69563     2394    -67169     
===========================================
- Hits        48120     2115    -46005     
+ Misses      21443      279    -21164     
Impacted Files Coverage Δ
build/c/src/core/autodetect.c
python/proton/_common.py
cpp/src/transport.cpp
cpp/src/reconnect_options.cpp
c/examples/broker.c
...est_PROTON_2116_blocking_connection_object_leak.py
cpp/src/returned.cpp
cpp/src/codec_test.cpp
cpp/examples/simple_send.cpp
cpp/examples/simple_connect.cpp
... and 285 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06c7e64...7c6ed41. Read the comment docs.

@jiridanek jiridanek force-pushed the jd_2021_05_13_DISPATCH-xxx_regenerate_keys branch from 0551a80 to adfac58 Compare May 18, 2021 16:46
@jiridanek jiridanek force-pushed the jd_2021_05_13_DISPATCH-xxx_regenerate_keys branch from adfac58 to 7c6ed41 Compare May 18, 2021 16:47
@jiridanek
Copy link
Contributor Author

Ok, now it should be there. Expiry in 100 years. Let the singularity robo machines that replace human civilization by that time deal with the maintenance then.

@jiridanek jiridanek merged commit bcb733d into apache:main May 18, 2021
@jiridanek jiridanek deleted the jd_2021_05_13_DISPATCH-xxx_regenerate_keys branch May 18, 2021 21:08
jiridanek added a commit to jiridanek/qpid-proton that referenced this pull request Jul 6, 2021
jiridanek added a commit to jiridanek/qpid-proton that referenced this pull request Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants