NO-JIRA: [Python] Allow configuration of container ID #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows simple external configuration of container ID. Without it the only way to overwrite or provide custom container ID is to inherit the class. Signed-off-by: Ievgen Popovych <ievgenp@seetrue.ai>
|
@Jmennius I've merged a neater version of this change with a test to make sure it works. Note you'll likely get a faster response at least from me) if you include a test or two for your changes. |
Thanks! will consider fort the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows simple external configuration of container ID.
Without it the only way to overwrite or provide custom container ID is to inherit the class.