Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proton-j : Upgrade BouncyCastle #74

Closed
wants to merge 2 commits into from
Closed

proton-j : Upgrade BouncyCastle #74

wants to merge 2 commits into from

Conversation

JemDay
Copy link
Contributor

@JemDay JemDay commented May 31, 2016

Changed to use a dependency.
Removed 'reflective' constructs.
Verified correct test operations with BC 1.48 and 1.54

Change to 'provided' dependency to simplify coding.
Full tests pass with BC 1.48 and 1.54
@JemDay
Copy link
Contributor Author

JemDay commented May 31, 2016

I'm not sure what the CI build is doing to cause it to fail but i can confirm that "mvn clean test" works for me from the command line .. see attached
build-log.txt

@gemmellr
Copy link
Member

gemmellr commented Jun 6, 2016

The CI builds are failing while running the cmake build (using it is outlined in DEVELOPERS.md) rather than the maven build. The cmake build creates a proton-j jar by itself for use in certain tests, a process which these changes break through introduction of a compile time dependency on bouncycastle that it doesn't accommodate because it didn't previously need to. Either the update needs to be made fully-reflective as before, or the cmake build updated to accommodate the new compilation dependency.

Some more general comments:

  • The main module and tests are specifying difference versions of bouncycastle to use.
  • If you include the JIRA title in the PR title, it will be updated by a bot upon PR open/comments/close.
  • Please reference the JIRA in commit msg, i.e "PROTON-XYZ: msg".
  • Please remove merge commits from PRs.

(Mentioning PROTON-1224 so it also gets updated)

@JemDay
Copy link
Contributor Author

JemDay commented Jun 7, 2016

OK .. i'll take a look at setting up a cmake environment and cleaning the commits..

@JemDay
Copy link
Contributor Author

JemDay commented Jun 10, 2016

Closing PR .. will recreate

@JemDay JemDay closed this Jun 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants