PROTON-1330: [python] bundle the C source in the python source distribution #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astitcher
reviewed
Nov 15, 2016
| file(MAKE_DIRECTORY ${py_dist_dir}/proton) | ||
| file(COPY ${pysrc} DESTINATION ${py_dist_dir}/proton) | ||
|
|
||
| #file(COPY ${py_dist_proton_c_files} |
There was a problem hiding this comment.
Do you really want to add commented out lines?
There was a problem hiding this comment.
Oopsie - no, not at all.
I'll fix that.
|
I like this approach. I was expecting to see the file lists substituted in setup.py.in somewhere. I didn't see that - how are the CMake file lists used inside setup.py to generate the source bundle? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This alters the previous approach: All c source files are enumerated in the CMakeLists.txt in the proton-c directory. The python CMakeLists.txt introduces a new target for the python source distribution, using the source lists from the parent CMakeLists.txt