PROTON-1355: Set ssl.peer_hostname to virtual_host if specified #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astitcher
reviewed
Nov 18, 2016
| @@ -565,7 +565,7 @@ def _connect(self, connection, reactor): | |||
| if not self.ssl_domain: | |||
| raise SSLUnavailable("amqps: SSL libraries not found") | |||
| self.ssl = SSL(transport, self.ssl_domain) | |||
| self.ssl.peer_hostname = url.host | |||
| self.ssl.peer_hostname = self.virtual_host if self.virtual_host != None else url.host | |||
There was a problem hiding this comment.
I'm pretty sure that None has truthiness of false so this can be written more simply as:
... = self.virtual_host if self.virtual_host else url.host
There was a problem hiding this comment.
Agreed. I chose to write it this way to be consistent with the rest of the code which seems to explicitly check for None.
There was a problem hiding this comment.
actually you can write it even more clearly ...
... = self.virtual_host or url.host
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.