RATIS-2126. Optimize NotLeaderException message #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szetszwo
reviewed
Jul 17, 2024
| @@ -30,7 +30,7 @@ public class NotLeaderException extends RaftException { | |||
| private final Collection<RaftPeer> peers; | |||
|
|
|||
| public NotLeaderException(RaftGroupMemberId memberId, RaftPeer suggestedLeader, Collection<RaftPeer> peers) { | |||
| super("Server " + memberId + " is not the leader" + (suggestedLeader != null? " " + suggestedLeader: "")); | |||
| super("Server " + memberId + " is not the leader" + (suggestedLeader != null ? " ,suggested leader is: " + suggestedLeader : "")); | |||
There was a problem hiding this comment.
@weimingdiit , thanks for working on this! The space should be after the comma, i.e. ", suggested ...".
There was a problem hiding this comment.
@szetszwo Ok, already updated, please review again
szetszwo
approved these changes
Jul 19, 2024
|
@weimingdiit , there is a checkstyle warning (long line). Could you fix it? |
|
szetszwo
pushed a commit
that referenced
this pull request
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Optimize NotLeaderException message
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-2126
How was this patch tested?
Original unit tests suite