This repository has been archived by the owner on Aug 4, 2022. It is now read-only.
[REEF-1428] Validate Task Stop failure => FailedTask Event #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addressed the issue by * Writing a test to validate that a Task Stop failure triggers a FailedTask Event. * Adding helper test classes. * Moving the call to TaskStop prior to setting the result of the Task. * Inject all ITaskStart and ITaskStop. JIRA: [REEF-1428](https://issues.apache.org/jira/browse/REEF-1428)
| { | ||
| stopHandler.OnNext(_taskStop.Value); | ||
| throw new TaskStopHandlerException("Encountered Exception on TaskStopHandler.", e); |
There was a problem hiding this comment.
Why catch exception in Stop but not start? Any specific exception you would expect?
There was a problem hiding this comment.
Start is addressed in another JIRA.
There was a problem hiding this comment.
Do we serialize TaskStopHandlerException to evalautor or eventually replaced it with SystemException in ContextRuntime? This is actually the exception from client's handler, right?
There was a problem hiding this comment.
This is the client's Exception. We serialize the client's Exception using InnerException, as seen in TaskRuntime.cs.
|
I completed a pass. |
|
@jwang98052 I've addressed your comments, please have another look. Thanks! |
|
LGTM. I will test and merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addressed the issue by
JIRA:
REEF-1428