[REEF-1431] Validate Task Message Receive failure => FailedEvaluator … #1057
Conversation
|
This will conflict with #1042. I'll perform the merge when one of them gets merged into master. Thanks! |
|
I will have a look. |
| } | ||
| catch (Exception e) | ||
| { | ||
| Utilities.Diagnostics.Exceptions.Caught(e, Level.Error, "Error during message delivery.", Logger); |
There was a problem hiding this comment.
So you want it ends up as FailedEvaluator instead of FailedTask, right? Can you document it?
There was a problem hiding this comment.
It is documented in the JIRA.
There was a problem hiding this comment.
I'll also add a comment here.
|
I completed a pass. |
|
@jwang98052 I've addressed your comments, please have another look. Thanks! |
|
LGTM with a minor comment. |
|
@jwang98052 I've replied to your comment. Thanks! |
|
I've resolved the conflict and merged with latest master. |
|
This PR shows conflicts again. Could you please resolve? |
|
I've resolved the conflict and merged with latest master. |
|
Conflicts again. |
|
Right...Git doesn't know how to resolve |
…Event This addressed the issue by * Changing the Evaluator to fail when throwing an Exception in the Driver message handler and adding a test. JIRA: [REEF-1431](https://issues.apache.org/jira/browse/REEF-1431)
|
@tcNickolas I've resolved the conflict, please have another look. Thanks! |
| /// <summary> | ||
| /// An test EventHandle that simply wraps around a <see cref="ManualResetEventSlim"/>. | ||
| /// </summary> | ||
| public sealed class EventHandle |
There was a problem hiding this comment.
Can we have a less generic name for this class? EventHandle has no information about what kind of event handling happens inside
There was a problem hiding this comment.
It doesn't handle an Event, it is a handle for an Event. I've renamed to EventMonitor for clarity.
|
@tcNickolas I've addressed your comment, please have another look. Thanks! |
|
LGTM, will merge |
…Event
This addressed the issue by
JIRA:
REEF-1431