This repository has been archived by the owner on Aug 4, 2022. It is now read-only.
[REEF-1476] Fix race condition in TestTwoSuccessiveTasksOnSameContext #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addressed the issue by * Join the task thread before checking the task status. JIRA: [REEF-1476](https://issues.apache.org/jira/browse/REEF-1476)
|
LGTM. Will test Did you find this race condition with some way of testing (so that I should try and repeat it)? I've never seen such test failure |
|
Yes, although appearing very rarely, it failed on my machine once. |
|
@tcNickolas Seems like there was another |
|
Actually, I'll just reopen the JIRA item and send a part-2 PR. |
afchung
added a commit
to afchung/reef
that referenced
this pull request
Jun 29, 2016
This addressed the issue by * Join the task thread before checking the task status. JIRA: [REEF-1476](https://issues.apache.org/jira/browse/REEF-1476) Pull request: This closes apache#1060
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addressed the issue by
JIRA:
REEF-1476