This repository has been archived by the owner on Aug 4, 2022. It is now read-only.
[REEF-1207] REEF.NET Evaluator should print a known log line on exit #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addressed the issue by * Adding constnats for the known Evaluator exit line. * Logging the lines on Evaluator Exit and ensuring that exits are only logged a single time. JIRA: [REEF-1207](https://issues.apache.org/jira/browse/REEF-1207)
| { | ||
| } | ||
|
|
||
| public void LogExit(bool successfulExit) |
|
I've done a pass. |
|
I will look at it. |
| @@ -208,11 +211,11 @@ public void OnNext(RuntimeStop runtimeStop) | |||
| } | |||
| catch (Exception e) | |||
| { | |||
| Utilities.Diagnostics.Exceptions.CaughtAndThrow(new InvalidOperationException("Cannot stop evaluator properly", e), Level.Error, "Exception during shut down.", Logger); | |||
| _evaluatorExitLogger.LogExit(false); | |||
| Utilities.Diagnostics.Exceptions.CaughtAndThrow( | |||
There was a problem hiding this comment.
Is EvaluatorExitLogger supposed to log the last line in evaluator, or it would want to replace current multiple unclear logs before evaluator exit? Here CaughtAndThrow will log again.
|
I completed a pass. |
|
@markusweimer @jwang98052 I've addressed your comments, please have another look. Thanks! |
|
LGTM |
|
LGTM, will tets and merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addressed the issue by
JIRA:
REEF-1207