Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Native] Support PanicHandler #354

Closed
xujianhai666 opened this issue Jan 3, 2020 · 2 comments
Closed

[Native] Support PanicHandler #354

xujianhai666 opened this issue Jan 3, 2020 · 2 comments
Labels
discuss Something undering disscussing enhancement New feature or request

Comments

@xujianhai666
Copy link
Member

The issue tracker is ONLY used for the go client (feature request of RocketMQ need to follow RIP process). Keep in mind, please check whether there is an existing same report before your raise a new one.

Alternately (especially if your communication is not a bug report), you can send mail to our mailing lists. We welcome any friendly suggestions, bug fixes, collaboration, and other improvements.

Please ensure that your bug report is clear and that it is complete. Otherwise, we may be unable to understand it or to reproduce it, either of which would prevent us from fixing the bug. We strongly recommend the report(bug report or feature request) could include some hints as to the following:

BUG REPORT
Please add the branch name [Native]/[Master] at the header of the Isssue title.

  1. Please describe the issue you observed:

    • What did you do (The steps to reproduce)?

    • What did you expect to see?

    • What did you see instead?

  2. Please tell us about your environment:

    • What is your OS?

    • What is your client version?

    • What is your RocketMQ version?

  3. Other information (e.g. detailed explanation, logs, related issues, suggestions on how to fix, etc):

FEATURE REQUEST

  1. Please describe the feature you are requesting.

  2. Provide any additional detail on your proposed use case for this feature.

  3. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue?

  4. If there are some sub-tasks using -[] for each subtask and create a corresponding issue to map to the sub task:

xujianhai666 added a commit to xujianhai666/rocketmq-client-go that referenced this issue Jan 3, 2020
@wenfengwang wenfengwang added the enhancement New feature or request label Jan 3, 2020
@wenfengwang wenfengwang added this to the 2.0.0-RC1 milestone Jan 3, 2020
@wenfengwang
Copy link
Member

The panic handler not needed in the client, because the logic of it should be controlled, any unexpected panic(error) should be fixed. if one has trouble with panic, there should add a panic handler by themself

@wenfengwang wenfengwang removed this from the 2.0.0-RC1 milestone Jan 6, 2020
@wenfengwang wenfengwang added the discuss Something undering disscussing label Jan 6, 2020
xujianhai666 added a commit to xujianhai666/rocketmq-client-go that referenced this issue Jan 7, 2020
wenfengwang pushed a commit that referenced this issue Jan 7, 2020
* feat: Support PanicHandler

Closes #354
@wenfengwang
Copy link
Member

after discussion, merge it, close due to #355

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Something undering disscussing enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants