fix(producer): UpdateNameServerAddress shoule be called before producer start, or namesrvs list will be empty, lead to a panic #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 28, 2020 14:43
…rt ; or end up with a failed publish
…namesrv will be empty, lead to a panic when publish
…er start, or namesrvs list will be empty, lead to a panic
ShannonDing
reviewed
Mar 11, 2020
| //if s.Size() == 0, response will be nil, lead to panic below. | ||
| if s.Size() == 0 { | ||
| rlog.Error("namesrv list empty. UpdateNameServerAddress should be called first.", map[string]interface{}{ | ||
| "namesrv": s, |
ShannonDing
approved these changes
Mar 11, 2020
Codecov Report
@@ Coverage Diff @@
## native #445 +/- ##
==========================================
- Coverage 24.82% 24.72% -0.11%
==========================================
Files 48 48
Lines 5547 5570 +23
==========================================
Hits 1377 1377
- Misses 3982 4003 +21
- Partials 188 190 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UpdateNameServerAddress shoule be called before producer start, or namesrvs list will be empty, lead to a panic。
Case: in private enviroment, start a consumer first, then start a producer, call publish. There whould be a panic.