Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #583] fix printlog crash #588

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Conversation

NAND86
Copy link
Contributor

@NAND86 NAND86 commented Jan 6, 2021

What is the purpose of the change

fix #583 pullMessage & printlog crash

Brief changelog

log print "pq.msgCache", it seems a typo causes this issue. "pq.cachedMsgCount" should be right here.

解决打印日志时发生的崩溃问题。
@codecov-io
Copy link

codecov-io commented Jan 6, 2021

Codecov Report

Merging #588 (cd6c9c0) into master (f07155b) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #588   +/-   ##
=======================================
  Coverage   24.22%   24.22%           
=======================================
  Files          48       48           
  Lines        5011     5011           
=======================================
  Hits         1214     1214           
  Misses       3598     3598           
  Partials      199      199           
Impacted Files Coverage Δ
consumer/push_consumer.go 11.46% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f07155b...cd6c9c0. Read the comment docs.

@ShannonDing ShannonDing added the bug Something isn't working label Jan 6, 2021
@ShannonDing ShannonDing merged commit 3af02f1 into apache:master Jan 7, 2021
@NAND86 NAND86 deleted the patch-1 branch April 22, 2021 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Master] pullMessage & printlog crash
3 participants