Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #735] centralized management errors #708

Merged
merged 5 commits into from
Nov 3, 2021

Conversation

180909
Copy link
Contributor

@180909 180909 commented Aug 7, 2021

What is the purpose of the change

Centralized management errors

Brief changelog

move all errors.New() to errors.go

@codecov-commenter
Copy link

Codecov Report

Merging #708 (98eaad3) into master (46701f1) will not change coverage.
The diff coverage is 29.41%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #708   +/-   ##
=======================================
  Coverage   25.70%   25.70%           
=======================================
  Files          49       49           
  Lines        6123     6123           
=======================================
  Hits         1574     1574           
  Misses       4335     4335           
  Partials      214      214           
Impacted Files Coverage Δ
consumer/consumer.go 16.34% <0.00%> (ø)
consumer/pull_consumer.go 0.00% <0.00%> (ø)
consumer/push_consumer.go 12.16% <0.00%> (ø)
internal/client.go 0.19% <ø> (ø)
internal/utils/compression.go 75.00% <0.00%> (ø)
internal/utils/errors.go 0.00% <ø> (ø)
internal/utils/net.go 56.52% <0.00%> (ø)
primitive/errors.go 0.00% <ø> (ø)
producer/producer.go 30.59% <33.33%> (ø)
primitive/base.go 41.17% <50.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46701f1...98eaad3. Read the comment docs.

@wenfengwang wenfengwang added this to the 2.2.0 milestone Sep 9, 2021
@wenfengwang
Copy link
Member

Could you create a related PR?

@180909
Copy link
Contributor Author

180909 commented Sep 9, 2021

Could you create a related PR?

This is PR

@wenfengwang
Copy link
Member

Could you create a related PR?

This is PR

sorry for my mistake, could you create a related issue for this PR?

@180909
Copy link
Contributor Author

180909 commented Oct 25, 2021

Could you create a related PR?

This is PR

sorry for my mistake, could you create a related issue for this PR?

Thanks for your focus, I create an issue: Centralized management errors for this PR.

@wenfengwang wenfengwang linked an issue Nov 3, 2021 that may be closed by this pull request
@wenfengwang wenfengwang changed the title centralized management errors [ISSUE #735] centralized management errors Nov 3, 2021
@wenfengwang wenfengwang merged commit 673760e into apache:master Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Centralized management errors
3 participants