Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[issue #778] Build instance name with nanosecond #779

Merged
merged 1 commit into from
Mar 9, 2022
Merged

[issue #778] Build instance name with nanosecond #779

merged 1 commit into from
Mar 9, 2022

Conversation

chaiyx
Copy link
Contributor

@chaiyx chaiyx commented Feb 24, 2022 •
edited by ShannonDing
Loading

close #778

@maixiaohai maixiaohai linked an issue Feb 28, 2022 that may be closed by this pull request
Build instance name with nanosecond #778
Closed
ShannonDing
ShannonDing approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@ShannonDing ShannonDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShannonDing ShannonDing merged commit 13e4bd6 into apache:master Mar 9, 2022
@ShannonDing ShannonDing added the enhancement New feature or request label Mar 9, 2022
ShannonDing added a commit that referenced this pull request May 27, 2022
@georgehao @chaiyx @ShannonDing
Feat/rpc request (#803)
a429f37 
* [Issue #778] Build instance name with nanosecond (#779)

[Issue #778] Build instance name with nanosecond (#779)

* Merge remote-tracking branch 'origin/master'

* Merge remote-tracking branch 'origin/master'

* feat: request reply producer

* feat: update

* feat: add consumer

* feat: fix ci

* feat: update

* feat: update

* feat: 修改request请求参数

* feat: modify async request for delete

* feat: fix go1.11 and go1.12 don't have time.Millseconds

* feat: move time.Millisecond() to duration/time.Millisecond

* feat: fix async request not remove requestResponseFutrue

Co-authored-by: chaiyx <chaiyx11@163.com>
Co-authored-by: Administrator <admin@example.com>
Co-authored-by: haohongfan1 <haohongfan1@jd.com>
Co-authored-by: dinglei <libya_003@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maixiaohai maixiaohai maixiaohai approved these changes

@duhenglucky duhenglucky duhenglucky approved these changes

@ShannonDing ShannonDing ShannonDing approved these changes

@Git-Yang Git-Yang Git-Yang approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build instance name with nanosecond
5 participants
@chaiyx @maixiaohai @duhenglucky @ShannonDing @Git-Yang