Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/rpc request #803

Merged
merged 22 commits into from
May 27, 2022
Merged

Feat/rpc request #803

merged 22 commits into from
May 27, 2022

Conversation

georgehao
Copy link
Contributor

What is the purpose of the change

add RPC request-response

examples/consumer/rpc/main.go Show resolved Hide resolved
internal/client.go Show resolved Hide resolved
internal/request_response_future.go Show resolved Hide resolved
internal/request_response_future.go Show resolved Hide resolved
internal/request_response_future.go Show resolved Hide resolved
producer/producer.go Show resolved Hide resolved
producer/producer.go Outdated Show resolved Hide resolved
producer/producer.go Show resolved Hide resolved
producer/producer.go Outdated Show resolved Hide resolved
Copy link
Member

@ShannonDing ShannonDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but seems conflict now.

func (rf *RequestResponseFuture) WaitResponseMessage(reqMsg *primitive.Message) (*primitive.Message, error) {
select {
case <-time.After(rf.Timeout):
err := fmt.Errorf("send request message to %s OK, but wait reply message timeout %d ms", reqMsg.Topic, rf.Timeout.Milliseconds())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seem not supported in go 1.11 and go 1.12

Copy link
Member

@ShannonDing ShannonDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShannonDing ShannonDing merged commit a429f37 into apache:master May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants