Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #823]fix: panic problem caused by json-iterator in go1.18 #841

Merged
merged 2 commits into from
Jun 15, 2022
Merged

[ISSUE #823]fix: panic problem caused by json-iterator in go1.18 #841

merged 2 commits into from
Jun 15, 2022

Conversation

yusank
Copy link
Contributor

@yusank yusank commented Jun 14, 2022

What is the purpose of the change

fixing client panic problem caused by low version of json-iterator

Brief changelog

update go version and json-iterator package version to latest.

Verifying this change

json-iterator repo has publish v1.1.12 to fix panic problem in go go1.18
image

@yusank
Copy link
Contributor Author

yusank commented Jun 14, 2022

#823

ShannonDing
ShannonDing approved these changes Jun 15, 2022
View reviewed changes
Copy link
Member

@ShannonDing ShannonDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShannonDing ShannonDing linked an issue Jun 15, 2022 that may be closed by this pull request
go1.18 consumer failed to start #823
Closed
@ShannonDing ShannonDing merged commit d86140d into apache:master Jun 15, 2022
@ShannonDing ShannonDing mentioned this pull request Jun 20, 2022
Closed
@ShannonDing ShannonDing linked an issue Jul 21, 2022 that may be closed by this pull request
[BUG] Run the example 'producer' #794
Closed
@ShannonDing ShannonDing added the enhancement New feature or request label Jul 21, 2022
@ShannonDing ShannonDing added this to the 2.1.1 milestone Jul 21, 2022
@ShannonDing ShannonDing mentioned this pull request Jul 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShannonDing ShannonDing ShannonDing approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.1.1
Development

Successfully merging this pull request may close these issues.

go1.18 consumer failed to start [BUG] Run the example 'producer'
2 participants
@yusank @ShannonDing