Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #882] keep queryTopicRouteInfoFromServer timeout the same as Java #880

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

twz915
Copy link
Contributor

@twz915 twz915 commented Aug 3, 2022

close #882
see detail https://github.com/apache/rocketmq/blob/4b5270a724d100ab87f56fdd06a4ba57571a02b9/client/src/main/java/org/apache/rocketmq/client/impl/MQAdminImpl.java#L143

https://github.com/apache/rocketmq/blob/4b5270a724d100ab87f56fdd06a4ba57571a02b9/client/src/main/java/org/apache/rocketmq/client/impl/MQAdminImpl.java#L65

What is the purpose of the change

Sometimes I met the error the topic=xxx route info not found, it may not exist, but Java works well in test environment.
So just keep the same timeout as Java to solve the problem.

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@ShannonDing ShannonDing changed the title keep queryTopicRouteInfoFromServer timeout the same as Java [ISSUE #882] keep queryTopicRouteInfoFromServer timeout the same as Java Aug 3, 2022
@ShannonDing ShannonDing added this to the 2.2.0 milestone Aug 3, 2022
@ShannonDing ShannonDing added the enhancement New feature or request label Aug 3, 2022
@ShannonDing ShannonDing merged commit 3ccfbff into apache:master Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep queryTopicRouteInfoFromServer timeout the same as Java SDK.
3 participants