-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ROCKETMQ-81] import rocketmq plugin for spark streaming #5
Conversation
@dongeforever @shroman @stevenschew thoughts? |
感谢 |
@vongosling There are two PRs for ROCKETMQ-81. I guess @hustfxj or @vesense will have to compile them in one, and they recheck it together :) Guys, please make sure you assign JIRA issues to yourselves before you start working on tasks, and update them. For instance, @hustfxj if you are working on the issue, please change the status, so @vesense knows you are working on it and doesn't waste his time. Two pull requests are submitted but the issue has still "Open" status :D In fact, I think it's pretty common to pick the issue and work on it if there is no progress on it for a long time. |
Agree with @shroman . |
@zhouxinyu yes, luckily they are :) |
I plan to merge these two PRs into one. @hustfxj What do you think about it? |
@vesense It's great! thank you |
@vesense How much the merge progress has been made now? |
@zhouxinyu Almost complete. I will submit it in this week. Some delay due to my computer wasn't working in the past few days. 😄 |
@vesense Thanks for your efforts~ 😄 |
I have completed the merging. The PR after merged is here: #4. Now I think we can merge it initially.
Thanks. |
This plugin is for spark streaming based on pull mode. And you can see READ.ME for more details. And we will add more tests for this plugin after that.