Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish the rocketmq-rocksdb pom and readme #925

Merged
merged 2 commits into from
Aug 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 21 additions & 7 deletions rocketmq-rocksdb/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## Summary

RocketMQ-RocksDB was introduced in RIP-66, and this document mainly introduces how to release related JAR.

rocketmq-rocksdb releases are a fat jar file that contain the following binaries:
* .so files for linux32 (glibc and musl-libc)
* .so files for linux64 (glibc and musl-libc)
Expand All @@ -13,16 +15,16 @@ rocketmq-rocksdb releases are a fat jar file that contain the following binaries
To build the binaries for a rocketmq-rocksdb release, follow the steps below.
1.git clone https://github.com/facebook/rocksdb.git

## file copy
## File copy
2.copy RemoveConsumeQueueCompactionFilter.java to rocksdb/java/src/main/java/org/rocksdb/
3.copy remove_consumequeue_compactionfilterjni.cc to rocksdb/java/rocksjni/
4.copy remove_consumequeue_compactionfilter.h to rocksdb/utilities/compaction_filters/
5.copy remove_consumequeue_compactionfilter.cc to rocksdb/utilities/compaction_filters/

## file replace
## File replace
6.replace rocksdb/thirdparty.inc with thirdparty.inc with

## file edit
## File edit
7.add the string "rocksjni/remove_consumequeue_compactionfilterjni.cc" to the file rocksdb/java/CMakeLists.txt
8.add the string "src/main/java/org/rocksdb/RemoveConsumeQueueCompactionFilter.java" to the file rocksdb/java/CMakeLists.txt
9.add the string "org.rocksdb.RemoveConsumeQueueCompactionFilter" to the file rocksdb/java/CMakeLists.txt
Expand All @@ -31,11 +33,11 @@ To build the binaries for a rocketmq-rocksdb release, follow the steps below.
12.add the string "java/rocksjni/remove_consumequeue_compactionfilterjni.cc \" to the file rocksdb/src.mk
13.add the string '"utilities/compaction_filters/remove_consumequeue_compactionfilter.cc",' to the file rocksdb/TARGETS

## file edit [optional] Some unexpected error may occur in compiling, you may change the warning level of compiling
## File edit [optional] Some unexpected error may occur in compiling, you may change the warning level of compiling
14.change 'set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /WX")' in file rocksdb/CMakeLists.txt to 'set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")'
15.change 'set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror")' in file rocksdb/CMakeLists.txt to 'set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")'

## file edit [important] it is important to change the DEBUG_LEVEL to 0 for releasing a official version
## File edit [important] it is important to change the DEBUG_LEVEL to 0 for releasing a official version
16.change 'DEBUG_LEVEL?=1' to 'DEBUG_LEVEL?=0' in file rocksdb/Makefile


Expand Down Expand Up @@ -123,11 +125,23 @@ Finally, run this make command from RocksDB's root source directory:
The resulting native binary will be built and available at `build\java\Release\rocksdbjni-shared.dll`. You can also find it under project folder with name `librocksdbjni-win64.dll`.


## copy `librocksdbjni-win64.dll` to `rocksdbjni-x.y.z.jar`
## Copy `librocksdbjni-win64.dll` to `rocksdbjni-x.y.z.jar`
jar -uf rocksdbjni-x.y.z.jar librocksdbjni-win64.dll

Finally, we use the following file to release an official rocksdb release for rocketmq:

rocksdbjni-x.y.z-javadoc.jar
rocksdbjni-x.y.z-sources.jar
rocksdbjni-x.y.z.jar
rocksdbjni-x.y.z.jar

## Release

```shell

mvn -X --settings settings.xml gpg:sign-and-deploy-file -Durl=https://repository.apache.org/service/local/staging/deploy/maven2 -DrepositoryId=apache.releases.https -DpomFile=pom.xml -Dfile=rocksdbjni-8.4.0.jar -Dclassifier= -Dgpg.keytype=RSA -Dgpg.passphrase=xxxxx

mvn -X --settings settings.xml gpg:sign-and-deploy-file -Durl=https://repository.apache.org/service/local/staging/deploy/maven2 -DrepositoryId=apache.releases.https -Dfile=rocksdbjni-8.4.0-javadoc.jar -Dclassifier=javadoc -Dgpg.keytype=RSA -Dgpg.passphrase=xxxxx

mvn -X --settings settings.xml gpg:sign-and-deploy-file -Durl=https://repository.apache.org/service/local/staging/deploy/maven2 -DrepositoryId=apache.releases.https -DpomFile=pom.xml -Dfile=rocksdbjni-8.4.0-sources.jar -Dclassifier=sources -Dgpg.keytype=RSA -Dgpg.passphrase=xxxxx

```
11 changes: 8 additions & 3 deletions rocketmq-rocksdb/pom.xml
Original file line number Diff line number Diff line change
@@ -1,10 +1,16 @@
<?xml version="1.0" encoding="UTF-8"?>
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
<parent>
<groupId>org.apache</groupId>
<artifactId>apache</artifactId>
<version>18</version>
</parent>

<modelVersion>4.0.0</modelVersion>

<groupId>org.apache.rocketmq</groupId>
<artifactId>rocketmq-rocksdb</artifactId>
<version>0.0.1</version>
<version>1.0.0</version>

<name>RocketMQ RocksDB JNI</name>
<description>RocksDB fat jar with modifications specific for Apache rocketmq that contains .so files for linux32 and linux64 (glibc and musl-libc), jnilib files
Expand Down Expand Up @@ -182,5 +188,4 @@
<scope>test</scope>
</dependency>
</dependencies>
</project>

</project>