Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Useless class file MessageFilterImpl #3565

Closed
ni-ze opened this issue Dec 1, 2021 · 2 comments · Fixed by #3575
Closed

Useless class file MessageFilterImpl #3565

ni-ze opened this issue Dec 1, 2021 · 2 comments · Fixed by #3575
Assignees
@TakshakRamteke
Labels
Good First Issue Good First Issue
Milestone
4.9.3

Comments

@ni-ze
Copy link
Contributor

ni-ze commented Dec 1, 2021

see: MessageFilterImpl

It is a useless file, it can be removed.
image
@duhenglucky duhenglucky added the Good First Issue Good First Issue label Dec 1, 2021
@duhenglucky duhenglucky added this to the 4.9.3 milestone Dec 1, 2021
@TakshakRamteke
Copy link
Contributor

TakshakRamteke commented Dec 1, 2021 •
edited
Loading

hello @duhenglucky, may i work on this one
sorry for the ping if it disturbed you in middle of something

@duhenglucky
Copy link
Contributor

@TakshakRamteke Welcome，go ahead

@TakshakRamteke TakshakRamteke mentioned this issue Dec 3, 2021
Merged
6 tasks
yuz10 pushed a commit that referenced this issue Dec 8, 2021
@TakshakRamteke @lushilin
[Issue #3565] Removing message filter impldev (#3575)
b5ade62 
* fix(broker): can not clear topic unitSubFlag (#3429)

Co-authored-by: lushilin <lushilin.me@bytedance.com>

* doc-optimization (#3523)

* Removed the Useless class file MessageFilterImpl.

Co-authored-by: lushilin <897401919@qq.com>
Co-authored-by: lushilin <lushilin.me@bytedance.com>
Co-authored-by: Smile <1494445739@qq.com>
@yuz10 yuz10 closed this as completed Dec 8, 2021
devfat pushed a commit to devfat/rocketmq that referenced this issue Mar 3, 2022
@TakshakRamteke @lushilin
[Issue apache#3565] Removing message filter impldev (apache#3575)
857467b 
* fix(broker): can not clear topic unitSubFlag (apache#3429)

Co-authored-by: lushilin <lushilin.me@bytedance.com>

* doc-optimization (apache#3523)

* Removed the Useless class file MessageFilterImpl.

Co-authored-by: lushilin <897401919@qq.com>
Co-authored-by: lushilin <lushilin.me@bytedance.com>
Co-authored-by: Smile <1494445739@qq.com>
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this issue Aug 12, 2022
@TakshakRamteke @lushilin
[Issue apache#3565] Removing message filter impldev (apache#3575)
8d42efa 
* fix(broker): can not clear topic unitSubFlag (apache#3429)

Co-authored-by: lushilin <lushilin.me@bytedance.com>

* doc-optimization (apache#3523)

* Removed the Useless class file MessageFilterImpl.

Co-authored-by: lushilin <897401919@qq.com>
Co-authored-by: lushilin <lushilin.me@bytedance.com>
Co-authored-by: Smile <1494445739@qq.com>
carlvine500 pushed a commit to carlvine500/rocketmq-apache that referenced this issue Sep 10, 2024
@TakshakRamteke @lushilin
[Issue apache#3565] Removing message filter impldev (apache#3575)
d9418f8 
* fix(broker): can not clear topic unitSubFlag (apache#3429)

Co-authored-by: lushilin <lushilin.me@bytedance.com>

* doc-optimization (apache#3523)

* Removed the Useless class file MessageFilterImpl.

Co-authored-by: lushilin <897401919@qq.com>
Co-authored-by: lushilin <lushilin.me@bytedance.com>
Co-authored-by: Smile <1494445739@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TakshakRamteke TakshakRamteke

Labels
Good First Issue Good First Issue
Projects
None yet
Milestone
4.9.3
Development

Successfully merging a pull request may close this issue.

[ISSUE #3565] Removing message filter impldev TakshakRamteke/rocketmq
4 participants
@duhenglucky @yuz10 @ni-ze @TakshakRamteke