Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused test scope log4j dependency for rocketmq-client #3635

Closed
Zanglei06 opened this issue Dec 13, 2021 · 1 comment · Fixed by #3636
Closed

remove unused test scope log4j dependency for rocketmq-client #3635

Zanglei06 opened this issue Dec 13, 2021 · 1 comment · Fixed by #3636
Labels
module/client
Milestone
4.9.3

Comments

@Zanglei06
Copy link
Contributor

log4j is not used in rocketmq-client, it is better to remove it to avoid security scans.
Zanglei06 pushed a commit to Zanglei06/rocketmq that referenced this issue Dec 13, 2021
[ISSUE apache#3635] remove log4j dependency in client pom
56b9447
areyouok pushed a commit that referenced this issue Dec 13, 2021
@Zanglei06
[ISSUE #3635] remove log4j dependency in client pom (#3636)
4a8263b 
Co-authored-by: zanglei <zanglei@kuaishou.com>
@duhenglucky duhenglucky added this to the 4.9.3 milestone Dec 13, 2021
@duhenglucky duhenglucky linked a pull request Dec 13, 2021 that will close this issue
[ISSUE #3635] remove log4j dependency in client pom #3636
Merged
@duhenglucky
Copy link
Contributor

Related with this issue

@duhenglucky duhenglucky mentioned this issue Dec 13, 2021
Closed
devfat pushed a commit to devfat/rocketmq that referenced this issue Mar 3, 2022
@Zanglei06
[ISSUE apache#3635] remove log4j dependency in client pom (apache#3636)
1f002ac 
Co-authored-by: zanglei <zanglei@kuaishou.com>
cserwen pushed a commit to cserwen/rocketmq that referenced this issue Apr 2, 2022
@Zanglei06 @Git-Yang
[ISSUE apache#3635] remove log4j dependency in client pom (apache#3636)
a044db2 
Co-authored-by: zanglei <zanglei@kuaishou.com>
Conflicts:
	client/pom.xml
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this issue Aug 12, 2022
@Zanglei06
[ISSUE apache#3635] remove log4j dependency in client pom (apache#3636)
8b5798b 
Co-authored-by: zanglei <zanglei@kuaishou.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module/client
Projects
None yet
Milestone
4.9.3
Development

Successfully merging a pull request may close this issue.

[ISSUE #3635] remove log4j dependency in client pom Zanglei06/rocketmq
2 participants
@Zanglei06 @duhenglucky